Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typography revamp #49

Merged
merged 11 commits into from
Jun 23, 2024
Merged

Typography revamp #49

merged 11 commits into from
Jun 23, 2024

Conversation

kawaijoe
Copy link
Member

No description provided.

kawaijoe and others added 9 commits June 22, 2024 23:48
* Fix separator throwing error in row

* Document badge

* Document button

* Document card

* Document dialog

* Document header

* Add documentation for remaining widgets

* Commit from GitHub Actions (Forui Presubmit)

* Fix golden images

* Commit from GitHub Actions (Forui Samples Presubmit)

* Fix gitignore

* Commit from GitHub Actions (Forui Samples Presubmit)

---------

Co-authored-by: Pante <[email protected]>
@kawaijoe kawaijoe marked this pull request as ready for review June 23, 2024 08:12
@kawaijoe kawaijoe requested a review from Pante June 23, 2024 08:12
@kawaijoe kawaijoe self-assigned this Jun 23, 2024
@kawaijoe kawaijoe added difficulty: medium Default/Normal difficulty. duration: small Features that take ~8 man-hours (or 1 man-day) priority: high Requires urgent attention, i.e. those that block progress of other features type: ehancement A new feature or request labels Jun 23, 2024
Copy link
Member

@Pante Pante left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally looks good, I think the section on scaling in CONTRIBUTING.md needs to be removed.

forui/lib/src/theme/theme.dart Show resolved Hide resolved
@kawaijoe kawaijoe merged commit e2065bd into master Jun 23, 2024
6 checks passed
@kawaijoe kawaijoe deleted the feature/typography-revamp branch June 23, 2024 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
difficulty: medium Default/Normal difficulty. duration: small Features that take ~8 man-hours (or 1 man-day) priority: high Requires urgent attention, i.e. those that block progress of other features type: ehancement A new feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants